[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/33] virtio-net: no writeable mac for virtio-1
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 07/33] virtio-net: no writeable mac for virtio-1 |
Date: |
Thu, 4 Jun 2015 12:34:16 +0200 |
From: Cornelia Huck <address@hidden>
Devices operating as virtio 1.0 may not allow writes to the mac
address in config space.
Signed-off-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/net/virtio-net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 0d3bf0f..e2d2ab5 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -87,6 +87,7 @@ static void virtio_net_set_config(VirtIODevice *vdev, const
uint8_t *config)
memcpy(&netcfg, config, n->config_size);
if (!virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_MAC_ADDR) &&
+ !virtio_has_feature(vdev, VIRTIO_F_VERSION_1) &&
memcmp(netcfg.mac, n->mac, ETH_ALEN)) {
memcpy(n->mac, netcfg.mac, ETH_ALEN);
qemu_format_nic_info_str(qemu_get_queue(n->nic), n->mac);
--
1.8.3.1
- [Qemu-devel] [PATCH 00/33] virtio 1.0 patch series rebased, Gerd Hoffmann, 2015/06/04
- [Qemu-devel] [PATCH 07/33] virtio-net: no writeable mac for virtio-1,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 05/33] virtio: disallow late feature changes for virtio-1, Gerd Hoffmann, 2015/06/04
- [Qemu-devel] [PATCH 01/33] virtio: 64bit features fixups., Gerd Hoffmann, 2015/06/04
- [Qemu-devel] [PATCH 09/33] virtio-net: enable virtio 1.0, Gerd Hoffmann, 2015/06/04
- [Qemu-devel] [PATCH 10/33] vhost_net: add version_1 feature, Gerd Hoffmann, 2015/06/04
- [Qemu-devel] [PATCH 03/33] virtio: allow virtio-1 queue layout, Gerd Hoffmann, 2015/06/04
- [Qemu-devel] [PATCH 02/33] virtio: endianness checks for virtio 1.0 devices, Gerd Hoffmann, 2015/06/04
- [Qemu-devel] [PATCH 17/33] virtio-pci: add flags to enable/disable legacy/modern, Gerd Hoffmann, 2015/06/04