Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

[Eric Blake]

On 06/05/2015 07:33 AM, Peter Maydell wrote:
> On 3 June 2015 at 22:45, Alexander Graf <address@hidden> wrote:
>> Hi Peter,
>>
>> This is my current patch queue for ppc.  Please pull.
> 
> This is applied, but can you fix the clang sanitizer warnings,
> please?
> 
> hw/ppc/spapr_drc.c:59:24: runtime error: left shift of negative value -1
> hw/ppc/spapr_drc.c:587:19: runtime error: left shift of negative value -1
> 
> Problem looks to be in:
> #define DRC_INDEX_ID_MASK (~(~0 << DRC_INDEX_TYPE_SHIFT))
> 
> which is doing left shifts on a negative signed number.

Might be as simple as using ~0U instead of ~0.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature