[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retriev
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retrieval (apparently) |
|
Date: |
Fri, 05 Jun 2015 15:47:49 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/05/2015 03:42 PM, Laszlo Ersek wrote:
> I found this qemu commit, ie.
>
> commit 65207c59d99f2260c5f1d3b9c491146616a522aa
> Author: Markus Armbruster <address@hidden>
> Date: Thu Mar 5 14:35:26 2015 +0100
>
> monitor: Drop broken, unused asynchronous command interface
>
> with bisection. Unfortunately, the bisection was extremely painful, because
> between a working version and today's pull, part of the qemu history was
> uncompileable. It was ultimately fixed with
> Which tells me that it's not individual capabilities that are broken by qemu
> 65207c59, but the entire libvirt capability retrieval. Apparently libvirt is
> one user of that async monitor interface. (The message on commit 65207c59
> itself mentions "qmp_capabilities".)
Libvirt doesn't use async capabilities, so much as Markus accidentally
broke the QMP protocol by completely ditching support for the "id"
member that libvirt uses on every synchronous QMP command. Several
threads already exist on the matter:
https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01806.html
https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01488.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature