Re: [Qemu-devel] [PATCH] machine: Drop use of DEFAULT_RAM_SIZE in help text

[Peter Maydell]

On 5 June 2015 at 10:05, Alexander Graf <address@hidden> wrote:
> As of commit 076b35b5a (machine: add default_ram_size to machine class) we
> no longer have a global default ram size, but instead machine specific
> defaults. When invoking qemu --help we don't know which machine you selected,
> so we can't tell the user the default RAM size in the help text anymore now.
>
> Thus I don't see an easy way to expose the default ram size to the user in the
> help text. The easiest option IMHO is to just drop this piece of information.
>
> Reported-by: Laurent Desnogues <address@hidden>
> Signed-off-by: Alexander Graf <address@hidden>
> ---
>  qemu-options.hx | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index b3db6cb..5eaba11 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -241,8 +241,7 @@ ETEXI
>  DEF("m", HAS_ARG, QEMU_OPTION_m,
>      "-m[emory] [size=]megs[,slots=n,maxmem=size]\n"
>      "                configure guest RAM\n"
> -    "                size: initial amount of guest memory (default: "
> -    stringify(DEFAULT_RAM_SIZE) "MiB)\n"
> +    "                size: initial amount of guest memory\n"
>      "                slots: number of hotplug slots (default: none)\n"
>      "                maxmem: maximum amount of guest memory (default: 
> none)\n"
>      "NOTE: Some architectures might enforce a specific granularity\n",

Applied to master as a fix.

thanks
-- PMM