[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror |
Date: |
Mon, 08 Jun 2015 08:51:35 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/07/2015 11:56 PM, Fam Zheng wrote:
> If specified as "true", it allows discarding on target sectors where source is
> not allocated.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/mirror.c | 8 ++++++--
> blockdev.c | 5 +++++
> hmp.c | 2 +-
> include/block/block_int.h | 2 ++
> qapi/block-core.json | 8 +++++++-
> qmp-commands.hx | 3 +++
> 6 files changed, 24 insertions(+), 4 deletions(-)
>
> +++ b/qapi/block-core.json
> @@ -973,6 +973,11 @@
> # @on-target-error: #optional the action to take on an error on the target,
> # default 'report' (no limitations, since this applies to
> # a different block device than @device).
> +# @unmap: #optional Whether to try to unmap target sectors where source has
> +# only zero. If true, and target unallocated sectors will read as
> zero,
> +# target image sectors will be unmapped; otherwise, zeroes will be
> +# written. Both will result in identical contents.
> +# Default is true. (Since 2.4)
> #
Per the other thread on adding 'detect-zeroes', should we instead be
using an enum here that describes one of several behaviors without an
explosion into multiple knobs?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors, Fam Zheng, 2015/06/08
- [Qemu-devel] [PATCH v7 1/8] block: Add bdrv_get_block_status_above, Fam Zheng, 2015/06/08
- [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror, Fam Zheng, 2015/06/08
- Re: [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror,
Eric Blake <=
- [Qemu-devel] [PATCH v7 3/8] mirror: Do zero write on target if sectors not allocated, Fam Zheng, 2015/06/08
- [Qemu-devel] [PATCH v7 4/8] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/06/08
- [Qemu-devel] [PATCH v7 5/8] block: Remove bdrv_reset_dirty, Fam Zheng, 2015/06/08
- [Qemu-devel] [PATCH v7 6/8] qemu-iotests: Make block job methods common, Fam Zheng, 2015/06/08
- [Qemu-devel] [PATCH v7 7/8] qemu-iotests: Add test case for mirror with unmap, Fam Zheng, 2015/06/08
- [Qemu-devel] [PATCH v7 8/8] iotests: Use event_wait in wait_ready, Fam Zheng, 2015/06/08
- Re: [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors, Stefan Hajnoczi, 2015/06/08