Re: [Qemu-devel] [PULL 0/3] Initial vfio-platform support

[Peter Maydell]

On 8 June 2015 at 18:06, Alex Williamson <address@hidden> wrote:
> The following changes since commit 2e29dd7c44db30e3d3c108ab2a622cbdac6d16f0:
>
>   Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into 
> staging (2015-06-08 14:07:32 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20150608.0
>
> for you to fetch changes up to 88be7b6bf4c86d89e70585881b6b3326f9bac822:
>
>   hw/vfio/platform: calxeda xgmac device (2015-06-08 09:25:26 -0600)
>
> ----------------------------------------------------------------
> Initial VFIO platform device support (Eric Auger, et al.)
>
> ----------------------------------------------------------------
> Eric Auger (3):
>       hw/vfio/platform: vfio-platform skeleton
>       hw/vfio/platform: add irq assignment
>       hw/vfio/platform: calxeda xgmac device

Hi. I'm afraid this doesn't build with clang:
  CC    m68k-softmmu/hw/virtio/vhost.o
/home/petmay01/linaro/qemu-for-merges/hw/vfio/calxeda-xgmac.c:26:33:
error: unused variable
      'vfio_platform_vmstate' [-Werror,-Wunused-const-variable]
static const VMStateDescription vfio_platform_vmstate = {
                                ^

Clang is pickier about some kinds of unused variable, and this
looks like a genuine bug -- you haven't actually connected the
VMStateDescription up to anything.

thanks
-- PMM