Re: [Qemu-devel] [PATCH v2 04/12] rdma typos

[Dr. David Alan Gilbert]

* Michael R. Hines (address@hidden) wrote:
> On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote:
> >From: "Dr. David Alan Gilbert" <address@hidden>
> >
> >A couple of typo fixes.
> >
> >Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> >---
> >  migration/rdma.c | 6 +++---
> >  trace-events     | 4 ++--
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> >diff --git a/migration/rdma.c b/migration/rdma.c
> >index bc73ff8..44ed996 100644
> >--- a/migration/rdma.c
> >+++ b/migration/rdma.c
> >@@ -1215,7 +1215,7 @@ const char *print_wrid(int wrid)
> >
> >  /*
> >   * Perform a non-optimized memory unregistration after every transfer
> >- * for demonsration purposes, only if pin-all is not requested.
> >+ * for demonstration purposes, only if pin-all is not requested.
> >   *
> >   * Potential optimizations:
> >   * 1. Start a new thread to run this function continuously
> >@@ -3279,7 +3279,7 @@ static void rdma_accept_incoming_migration(void 
> >*opaque)
> >      QEMUFile *f;
> >      Error *local_err = NULL, **errp = &local_err;
> >
> >-    trace_qemu_dma_accept_incoming_migration();
> >+    trace_qemu_rdma_accept_incoming_migration();
> >      ret = qemu_rdma_accept(rdma);
> >
> >      if (ret) {
> >@@ -3287,7 +3287,7 @@ static void rdma_accept_incoming_migration(void 
> >*opaque)
> >          return;
> >      }
> >
> >-    trace_qemu_dma_accept_incoming_migration_accepted();
> >+    trace_qemu_rdma_accept_incoming_migration_accepted();
> >
> >      f = qemu_fopen_rdma(rdma, "rb");
> >      if (f == NULL) {
> >diff --git a/trace-events b/trace-events
> >index 2662ffa..8b468fe 100644
> >--- a/trace-events
> >+++ b/trace-events
> >@@ -1398,8 +1398,8 @@ migrate_pending(uint64_t size, uint64_t max) "pending 
> >size %" PRIu64 " max %" PR
> >  migrate_transferred(uint64_t tranferred, uint64_t time_spent, double 
> > bandwidth, uint64_t size) "transferred %" PRIu64 " time_spent %" PRIu64 " 
> > bandwidth %g max_size %" PRId64
> >
> >  # migration/rdma.c
> >-qemu_dma_accept_incoming_migration(void) ""
> >-qemu_dma_accept_incoming_migration_accepted(void) ""
> >+qemu_rdma_accept_incoming_migration(void) ""
> >+qemu_rdma_accept_incoming_migration_accepted(void) ""
> 
> What happened to the actual message inside the quotes? =)

You don't need them in most cases; the trace tools normally print
the name of the event.

Dave

> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK