[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/16] qapi: Move exprs checking from parse_sche
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 09/16] qapi: Move exprs checking from parse_schema() to check_exprs() |
Date: |
Fri, 12 Jun 2015 17:41:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> To have expression semantic analysis in one place rather than two.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi.py | 142
> ++++++++++++++++++++++++++------------------------------
> 1 file changed, 66 insertions(+), 76 deletions(-)
Again, yay for a good testsuite proving this doesn't mess things up :)
> +
> + return map(lambda expr_elem: expr_elem['expr'], exprs)
I had to go research what this actually does, but it looks correct.
>
> def parse_schema(fname):
> - global all_names
> - exprs = []
> -
> - # First pass: read entire file into memory
> try:
> schema = QAPISchema(open(fname, "r"))
> + return check_exprs(schema.exprs)
> except (QAPISchemaError, QAPIExprError), e:
> print >>sys.stderr, e
> exit(1)
Wow, that's really just a thin wrapper now!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 08/16] qapi: Fix to reject stray 't', 'f' and 'n', (continued)
- [Qemu-devel] [PATCH 05/16] qapi: Improve a couple of confusing variable names, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 14/16] qapi-types: Drop unused members parameters, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 16/16] qapi-types: Bury code dead since commit 6b5abc7, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 10/16] qapi: Better separate the different kinds of helpers, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 09/16] qapi: Move exprs checking from parse_schema() to check_exprs(), Markus Armbruster, 2015/06/12
- Re: [Qemu-devel] [PATCH 09/16] qapi: Move exprs checking from parse_schema() to check_exprs(),
Eric Blake <=
- [Qemu-devel] [PATCH 15/16] qapi-types: Split generate_fwd_builtin() off generate_fwd_struct(), Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 11/16] tests/qapi-schema: New flat union array branch test case, Markus Armbruster, 2015/06/12