[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v1 5/8] qom: Disallow getting/resolving an overl
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [RFC PATCH v1 5/8] qom: Disallow getting/resolving an overloaded property |
Date: |
Sun, 14 Jun 2015 15:37:10 -0700 |
Using a getter or trying to resolve an overloaded property is
ambiguous. Disallow it.
Signed-off-by: Peter Crosthwaite <address@hidden>
---
qom/object.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/qom/object.c b/qom/object.c
index 967ed0d..1590df7 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -827,6 +827,9 @@ void object_property_get(Object *obj, Visitor *v, const
char *name,
if (!prop->get) {
error_set(errp, QERR_PERMISSION_DENIED);
+ } else if (prop->overloaded) {
+ error_setg(errp, "Overloaded property '.%s' getter not supported\n",
+ name);
} else {
prop->get(obj, v, prop->opaque, name, errp);
}
@@ -1352,7 +1355,7 @@ gchar *object_get_canonical_path(Object *obj)
Object *object_resolve_path_component(Object *parent, const gchar *part)
{
ObjectProperty *prop = object_property_find(parent, part, NULL);
- if (prop == NULL) {
+ if (prop == NULL || prop->overloaded) {
return NULL;
}
--
2.4.3.3.g905f831
- [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs, Peter Crosthwaite, 2015/06/14
- [Qemu-devel] [RFC PATCH v1 1/8] qom: Refactor array property code path, Peter Crosthwaite, 2015/06/14
- [Qemu-devel] [RFC PATCH v1 2/8] qom: Add property overloading, Peter Crosthwaite, 2015/06/14
- [Qemu-devel] [RFC PATCH v1 3/8] qom: Implement overloaded property setters, Peter Crosthwaite, 2015/06/14
- [Qemu-devel] [RFC PATCH v1 4/8] qom: Delete all instances of an overloaded property, Peter Crosthwaite, 2015/06/14
- [Qemu-devel] [RFC PATCH v1 5/8] qom: Disallow getting/resolving an overloaded property,
Peter Crosthwaite <=
- [Qemu-devel] [RFC PATCH v1 6/8] qom: Enable overloading of Alias properties, Peter Crosthwaite, 2015/06/14
- [Qemu-devel] [RFC PATCH v1 7/8] arm: realview: Factor out CPU property setters, Peter Crosthwaite, 2015/06/14
- [Qemu-devel] [RFC PATCH v1 8/8] arm: axxmpcore: Add CPUs to MPCore, Peter Crosthwaite, 2015/06/14
- Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs, Liviu Ionescu, 2015/06/15
- Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs, Alistair Francis, 2015/06/18