[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError |
Date: |
Tue, 16 Jun 2015 09:35:14 -0400 |
On Tue, 16 Jun 2015 15:08:41 +0200
Markus Armbruster <address@hidden> wrote:
> Luiz Capitulino <address@hidden> writes:
>
> > On Sat, 13 Jun 2015 16:20:47 +0200
> > Markus Armbruster <address@hidden> wrote:
> >
> >> After a bit over a year and many patches, QError is finally ripe. All
> >> that's left of qerror.h after this series is a bunch of QERR_ macros.
> >> Killing them is left for another day.
> >
> > Excellent!
> >
> > I did my best to review this series, but unfortunately my review is
> > a bit weak because I'm not that familiar with some code paths
> > (like QemuOpts) and I was unable to apply patches starting with patch 04/11.
>
> Did you apply on top of my "[PATCH v2 0/7] qdev: Mostly wean off
> QError"?
No, I assumed it was already merged.
> > But it does look good to me:
> >
> > Reviewed-by: Luiz Capitulino <address@hidden>
>
> Thanks!
>
- Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed, (continued)