Re: [Qemu-devel] [PATCH v2 6/6] audio: -audiodev command line option

[Markus Armbruster]

"Kővágó, Zoltán" <address@hidden> writes:

> This patch adds an -audiodev command line option, and deprecates the QEMU_*
> environment variables for audio backend configuration. It's syntax is similar 
> to
> existing options (-netdev, -device, etc):
>  -audiodev driver_name,property=value,...

Sounds really good.

Please wrap your commit message lines a bit earlier, around column 70.

> Audio drivers now get an Audiodev * as config paramters, instead of the global
> audio_option structs. There is some code in audio/audio_legacy.c that converts
> the old environment variables to audiodev options (this way backends do not 
> have
> to worry about legacy options, also print out them with -audio-help, to ease
> migrating to -audiodev).

The parenthesis isn't as clear as the rest of your message, probably
because it deals with two separate things.  Suggest to move out the bit
about help into its own paragraph.

> Although now it's possible to specify multiple -audiodev options on command
> line, multiple audio backends are not supported yet.

What happens when I specify multiple -audiodev?

How should the command line look like when multiple audio backends are
supported?

Do we have a clear backward-compatible path from here to there?

[...]
>  18 files changed, 994 insertions(+), 1083 deletions(-)
>  create mode 100644 audio/audio_legacy.c

Very nice delta, but the size is a bit intimidating :)

[...]