Re: [Qemu-devel] [PATCH v2 0/5] More core code ENV_GET_CPU() removals

[Eduardo Habkost]

On Wed, Jun 17, 2015 at 01:16:21PM -0700, Peter Crosthwaite wrote:
> On Wed, Jun 17, 2015 at 11:51 AM, Eduardo Habkost <address@hidden> wrote:
> > On Tue, Jun 16, 2015 at 12:41:56AM -0700, Peter Crosthwaite wrote:
> >> Hi Andreas, Richard and all,
> >>
> >> I'm moving towards the goal of having no core code usages of ENV_GET_CPU.
> >> This has two advantages:
> >>
> >> 1: It means we are closer to common-obj'ing core code like exec.c, cpus.c
> >> and friends.
> >> 2: Multi arch is easier if ENV_GET_CPU() stays arch specific. It means I
> >> don't need those patches where I reorder the env within the arch specific
> >> CPUState. This allows continuing placement of arch specifics before the
> >> env in the CPU container (which has TCG perf advantages).
> >>
> >> Due to point 1, I'm sending this ahead as I think it has standalone value,
> >> rather than send as part of multi-arch.
> >
> > Do you have a git tree? Your series seems to require a version of
> > Bharata's CPU bitmap series to be applied first, but I don't know which
> > one. I also see a small conflict on arm_cpu_initfn() due to commit
> > eb5e1d3c85dffe677da2550d211f9304a7d5ba3b ("target-arm: Use the kernel's
> > idea of MPIDR if we're using KVM").
> >
> 
> I can make one, but I need to respin this due to Aurelien's comments
> on P5. Do you just want an all-in-one series?

Whatever works for you (while letting people know how to cleanly apply
your series for testing). A git tree is just one way to do it.

If in the next version you just point to the qemu.git commit used as
base and mention the specific patch series version(s) you applied before
yours, it should be enough.

-- 
Eduardo