Re: [Qemu-devel] [PATCH v3 2/3] target-i386: reserve RCRB mmio space in ACPI DSDT table

[Paulo Alcantara]

On Wed, 17 Jun 2015 15:33:07 +0200
"Michael S. Tsirkin" <address@hidden> wrote:

> On Mon, Jun 01, 2015 at 08:48:40PM -0300, Paulo Alcantara wrote:
> > v1 -> v2:
> >   * s/PDRC/CCR/ for clarity and match ICH9 spec
> >   * remove unnecessary OperationRegion for RCRB
> 
> changelog should come after ---.

Ok.

> An empty commit log is too terse I think.
> Could you quote spec in the changelog?

Yes, sure.

> 
> > Signed-off-by: Paulo Alcantara <address@hidden>
> > ---
> >  hw/i386/q35-acpi-dsdt.dsl     |  14 ++++++++++++++
> >  tests/acpi-test-data/q35/DSDT | Bin 7666 -> 7723 bytes
> >  2 files changed, 14 insertions(+)
> > 
> > diff --git a/hw/i386/q35-acpi-dsdt.dsl b/hw/i386/q35-acpi-dsdt.dsl
> > index 16eaca3..92675c8 100644
> > --- a/hw/i386/q35-acpi-dsdt.dsl
> > +++ b/hw/i386/q35-acpi-dsdt.dsl
> > @@ -114,6 +114,20 @@ DefinitionBlock (
> >          }
> >      }
> >  
> > +/****************************************************************
> > + * Chipset Configuration Registers
> > + ****************************************************************/
> > +Scope(\_SB.PCI0) {
> > +    Device (CCR) {
> > +        Name (_HID, EISAID("PNP0C02"))
> > +        Name (_UID, 1)
> > +
> > +        Name (_CRS, ResourceTemplate() {
> > +       Memory32Fixed(ReadWrite, 0xfed1c000, 0x00004000) //
> > RCBA
> 
> Indent a bit more please.

Ok.

Thanks,

Paulo

-- 
Paulo Alcantara, C.E.S.A.R
Speaking for myself only.