[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpu-exec: Do not invalidate original TB in cpu_
|
From: |
Sergey Fedorov |
|
Subject: |
Re: [Qemu-devel] [PATCH] cpu-exec: Do not invalidate original TB in cpu_exec_nocache() |
|
Date: |
Thu, 18 Jun 2015 13:09:09 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 18.06.2015 09:57, Paolo Bonzini wrote:
> On 17/06/2015 19:54, Sergey Fedorov wrote:
>>
>> - /* tb_gen_code can flush our orig_tb, invalidate it now */
>> - tb_phys_invalidate(orig_tb, -1);
>> - tb = tb_gen_code(cpu, pc, cs_base, flags,
>> + tb = tb_gen_code(cpu, orig_tb->pc, orig_tb->cs_base, orig_tb->flags,
>> max_cycles | CF_NOCACHE);
>> + tb->orig_tb = orig_tb;
> What happens here if tb_gen_code calls tb_flush?
>
> Paolo
I think I understand. Did you mean tcg_ctx.tb_ctx.tb_invalidated_flag
should be checked here?
Sergey