[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_set_state() |
Date: |
Thu, 18 Jun 2015 11:47:02 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Juan Quintela (address@hidden) wrote:
> We now use the helper everywhere, so no need to call this on this two
> places. See on previous commit that there were a place where we missed
> to mark the trace. Now all tracing is done in migrate_set_state().
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration/migration.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 1c84249..b31c7f4 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -546,7 +546,6 @@ void migrate_fd_error(MigrationState *s)
> trace_migrate_fd_error();
> assert(s->file == NULL);
> migrate_set_state(s, MIGRATION_STATUS_SETUP, MIGRATION_STATUS_FAILED);
> - trace_migrate_set_state(MIGRATION_STATUS_FAILED);
> notifier_list_notify(&migration_state_notifiers, s);
> }
>
> @@ -631,7 +630,6 @@ static MigrationState *migrate_init(const MigrationParams
> *params)
> decompress_thread_count;
> s->bandwidth_limit = bandwidth_limit;
> migrate_set_state(s, MIGRATION_STATUS_NONE, MIGRATION_STATUS_SETUP);
> - trace_migrate_set_state(MIGRATION_STATUS_SETUP);
>
> s->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
> return s;
> --
> 2.4.3
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 01/11] runstate: Add runstate store, (continued)
- [Qemu-devel] [PATCH 01/11] runstate: Add runstate store, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 03/11] migration: create new section to store global state, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 05/11] vmstate: Create optional sections, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 04/11] global_state: Make section optional, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 06/11] migration: Add configuration section, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_set_state(), Juan Quintela, 2015/06/16
- Re: [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_set_state(),
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 08/11] migration: Use always helper to set state, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 07/11] migration: Use cmpxchg correctly, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 10/11] migration: create migration event, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 11/11] migration: Add migration events on target side, Juan Quintela, 2015/06/16