qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 3/7] hw/pci-bridge: introduce "hotplug" prope


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v6 3/7] hw/pci-bridge: introduce "hotplug" property
Date: Thu, 18 Jun 2015 16:44:08 +0200

On Thu, Jun 18, 2015 at 03:47:41PM +0200, Paolo Bonzini wrote:
> 
> 
> On 17/06/2015 16:02, Michael S. Tsirkin wrote:
> > > Are you okay with the flag's name, PCI_BRIDGE_DEV_F_HOTPLUG? If not,
> > > what would be your preference?
> > 
> > PCI_BRIDGE_DEV_F_SHPC_REQ
> 
> Do not abbrev unless necessary. :)  What about PCI_BRIDGE_DEV_F_HAS_SHPC
> or even just PCI_BRIDGE_DEV_F_SHPC?
> 
> Paolo

The point of _REQ is that it's requested by user.
This avoids confusion with two other flags,
one checking whether a feature is present, another
whether it's enabled.

> > Also add macro for "shpc" property string to avoid duplication.
> > Also clear msi explicitly - no need for that to depend on shpc.
> > 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]