[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 3/8] ppc: Move cpu_exec_init() call to realize fu
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [PATCH v3 3/8] ppc: Move cpu_exec_init() call to realize function |
Date: |
Thu, 18 Jun 2015 10:24:50 -0700 |
From: Bharata B Rao <address@hidden>
Move cpu_exec_init() call from instance_init to realize. This allows
any failures from cpu_exec_init() to be handled appropriately.
Also add corresponding cpu_exec_exit() call from unrealize.
cpu_dt_id assignment from instance_init is no longer needed since
correct assignment for cpu_dt_id is already present in realizefn.
Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Peter Crosthwaite <address@hidden>
---
target-ppc/translate_init.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 52d95ce..2b72f2d 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -8928,6 +8928,11 @@ static void ppc_cpu_realizefn(DeviceState *dev, Error
**errp)
return;
}
+ cpu_exec_init(&cpu->env, &local_err);
+ if (local_err != NULL) {
+ error_propagate(errp, local_err);
+ return;
+ }
cpu->cpu_dt_id = (cs->cpu_index / smp_threads) * max_smt
+ (cs->cpu_index % smp_threads);
#endif
@@ -9141,6 +9146,8 @@ static void ppc_cpu_unrealizefn(DeviceState *dev, Error
**errp)
opc_handler_t **table;
int i, j;
+ cpu_exec_exit(CPU(dev));
+
for (i = 0; i < PPC_CPU_OPCODES_LEN; i++) {
if (env->opcodes[i] == &invalid_handler) {
continue;
@@ -9633,8 +9640,6 @@ static void ppc_cpu_initfn(Object *obj)
CPUPPCState *env = &cpu->env;
cs->env_ptr = env;
- cpu_exec_init(env, &error_abort);
- cpu->cpu_dt_id = cs->cpu_index;
env->msr_mask = pcc->msr_mask;
env->mmu_model = pcc->mmu_model;
--
1.9.1
- [Qemu-devel] [PATCH v3 0/8] More core code ENV_GET_CPU removals, Peter Crosthwaite, 2015/06/18
- [Qemu-devel] [PATCH v3 1/8] cpus: Add Error argument to cpu_exec_init(), Peter Crosthwaite, 2015/06/18
- [Qemu-devel] [PATCH v3 3/8] ppc: Move cpu_exec_init() call to realize function,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v3 5/8] gdbserver: _fork: Change fn to accept cpu instead of env, Peter Crosthwaite, 2015/06/18
- [Qemu-devel] [PATCH v3 4/8] translate-all: Change tb_flush() env argument to cpu, Peter Crosthwaite, 2015/06/18
- [Qemu-devel] [PATCH v3 6/8] cpus: Change tcg_cpu_exec arg to cpu, not env, Peter Crosthwaite, 2015/06/18
- [Qemu-devel] [PATCH v3 2/8] cpus: Convert cpu_index into a bitmap, Peter Crosthwaite, 2015/06/18
- [Qemu-devel] [PATCH v3 7/8] cpus: Change exec_init() arg to cpu, not env, Peter Crosthwaite, 2015/06/18
- [Qemu-devel] [PATCH v3 8/8] cpu-exec: Purge all uses of ENV_GET_CPU(), Peter Crosthwaite, 2015/06/18