[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: Do not reset sysregs marked as ALIA
|
From: |
Sergey Fedorov |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: Do not reset sysregs marked as ALIAS |
|
Date: |
Fri, 19 Jun 2015 00:03:42 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 19.06.2015 00:01, Peter Maydell wrote:
> On 18 June 2015 at 21:57, Sergey Fedorov <address@hidden> wrote:
>> On 18.06.2015 23:46, Peter Maydell wrote:
>>> On 17 June 2015 at 16:25, Sergey Fedorov <address@hidden> wrote:
>>>> cp_reg_reset() is called from g_hash_table_foreach() which does not
>>>> define a specific ordering of the hash table iteration. Thus doing reset
>>>> for registers marked as ALIAS would give an ambiguous result when
>>>> resetvalue is different for original and alias resisters.
>>> Was this actually the case for any of our registers? ie, is this
>>> patch fixing a bug, or just cleaning up a potential cause of
>>> confusion?
>> Peter, I discovered such a confusing behavior for PMCR register and
>> decided to sort this out.
> Ah yes, nice catch. I'll fix up the commit message.
>
> -- PMM
Thanks!