Re: [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail()

[Andreas Färber]

Am 13.06.2015 um 13:18 schrieb Markus Armbruster:
> It's a perfectly sensible helper function.

But only in the current state. Once/if we just set realized=true on
/machine level, then no other helper functions will need to set it, as
pointed out in the following paragraph.

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  include/hw/qdev-core.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index 5789b91..fbfc741 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -65,8 +65,6 @@ struct VMStateDescription;
>   * Operations depending on @props static properties should go into @realize.
>   * After successful realization, setting static properties will fail.
>   *
> - * As an interim step, the #DeviceState:realized property is set by 
> deprecated
> - * function qdev_init_nofail().
>   * In the future, devices will propagate this state change to their children
>   * and along busses they expose.
>   * The point in time will be deferred to machine creation, so that values

Nack to the patch as is. I would be much more open to it if you just
removed the word "deprecated" rather than the full paragraph explaining
where it is currently set.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)