[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/1] vvfat label option updated
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/1] vvfat label option updated |
Date: |
Fri, 19 Jun 2015 13:50:31 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 19, 2015 at 11:35:28AM +0200, Wolfgang Bumiller wrote:
> * Till/Until changed
> * Added (since 2.4) to json file
> * Added the 11-byte limit description. Without mentioning the trailing
> spaces in the json file since the guest OS doesn't expose them to
> the user. However, I mentioned it in the commit message.
>
> The limit comes from the FAT structure, but for completeness' sake I
> looked up the FAT descriptions a little more. Turns out at least
> FAT32 labels are "supposed" to be stored with uppercase letters, and
> seem to have some theoretical restrictions on the used characters, but
> neither linux nor windows guests seem to care on the OS side. And at
> least mkfs.vfat's -n option only warns about lowercase letters, but
> doesn't error. Theoretically you're also not allowed to start a label
> with a space, while mkfs.vfat neither warns nor errors about this.
> So I decided to not add any additional checks and only mentioned it in
> the json's doc string.
>
> Wolfgang Bumiller (1):
> vvfat: add a label option
>
> block/vvfat.c | 25 ++++++++++++++++++++++---
> qapi/block-core.json | 6 +++++-
> 2 files changed, 27 insertions(+), 4 deletions(-)
>
> --
> 2.1.4
>
>
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpn6xfz0SmWu.pgp
Description: PGP signature