[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target-i386: emulate CPUID level of real har
From: |
Radim Krčmář |
Subject: |
Re: [Qemu-devel] [PATCH v2] target-i386: emulate CPUID level of real hardware |
Date: |
Mon, 22 Jun 2015 12:41:48 +0200 |
2015-06-19 12:52-0300, Eduardo Habkost:
> On Fri, Jun 19, 2015 at 01:20:40PM +0200, Radim Krčmář wrote:
> [...]
> > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> > @@ -307,6 +307,24 @@ static void pc_init1(MachineState *machine)
> > static void pc_compat_2_3(MachineState *machine)
> > {
> > savevm_skip_section_footers();
> > +
> > + x86_cpu_compat_set_level("qemu64", 4);
| [...]
> > +
> > + x86_cpu_compat_set_xlevel("n270", 0x8000000a);
| [...]
>
> We can simply use set the "level" and "xlevel" properties on
> PC_COMPAT_2_3, we don't need the x86_cpu_compat_set_*level() functions.
Oops, thanks, I will convert the code and send v3.