[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/24] monitor: remove debug prints
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 03/24] monitor: remove debug prints |
Date: |
Mon, 22 Jun 2015 21:04:28 +0200 |
From: Bandan Das <address@hidden>
The preferred solution is to use tracepoints and there
is good chance of bitrot with the debug prints not being
enabled at compile time. Remove them.
Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Bandan Das <address@hidden>
Acked-by: Luiz Capitulino <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
monitor.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/monitor.c b/monitor.c
index 79de805..04e94e0 100644
--- a/monitor.c
+++ b/monitor.c
@@ -81,9 +81,6 @@
#endif
#include "hw/lm32/lm32_pic.h"
-//#define DEBUG
-//#define DEBUG_COMPLETION
-
/*
* Supported types:
*
@@ -3661,10 +3658,6 @@ static const mon_cmd_t *monitor_parse_command(Monitor
*mon,
char buf[1024];
char *key;
-#ifdef DEBUG
- monitor_printf(mon, "command='%s', start='%d'\n", cmdline, start);
-#endif
-
/* extract the command name */
p = get_command_name(cmdline + start, cmdname, sizeof(cmdname));
if (!p)
@@ -4115,10 +4108,7 @@ static void file_completion(Monitor *mon, const char
*input)
path[input_path_len] = '\0';
pstrcpy(file_prefix, sizeof(file_prefix), p + 1);
}
-#ifdef DEBUG_COMPLETION
- monitor_printf(mon, "input='%s' path='%s' prefix='%s'\n",
- input, path, file_prefix);
-#endif
+
ffs = opendir(path);
if (!ffs)
return;
@@ -4696,14 +4686,6 @@ static void monitor_find_completion(void *opaque,
if (parse_cmdline(cmdline, &nb_args, args) < 0) {
return;
}
-#ifdef DEBUG_COMPLETION
- {
- int i;
- for (i = 0; i < nb_args; i++) {
- monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
- }
- }
-#endif
/* if the line ends with a space, it means we want to complete the
next arg */
--
1.9.3
- [Qemu-devel] [PULL 00/24] Monitor patches, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 03/24] monitor: remove debug prints,
Markus Armbruster <=
- [Qemu-devel] [PULL 05/24] monitor: Point to "help" command on syntax error, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 06/24] monitor: Fix failure path for "S" argument, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 12/24] qdev-monitor: Propagate errors through set_property(), Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 04/24] monitor: cleanup parsing of cmd name and cmd arguments, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 10/24] qdev-monitor: Fix check for full bus, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 09/24] qdev-monitor: Stop error avalanche in qbus_find_recursive(), Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 13/24] qdev-monitor: Propagate errors through qdev_device_add(), Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 15/24] vl: Avoid qerror_report() outside QMP command handlers, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 11/24] qdev-monitor: Convert qbus_find() to Error, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PULL 01/24] qobject: Use 'bool' for qbool, Markus Armbruster, 2015/06/22