[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/10] crypto: move built-in D3DES implementa
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/10] crypto: move built-in D3DES implementation into crypto/ |
Date: |
Tue, 23 Jun 2015 10:12:16 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/6/19 1:02, Daniel P. Berrange wrote:
> To prepare for a generic internal cipher API, move the
> built-in D3DES implementation into the crypto/ directory.
>
> This is not in fact a normal D3DES implementation, it is
> D3DES with double & triple length modes removed, and the
> key bytes in reversed bit order. IOW it is crippled
> specifically for the "benefit" of RFB, so call the new
> files desrfb.c instead of d3des.c to make it clear that
> it isn't a generally useful impl.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> crypto/Makefile.objs | 1 +
> ui/d3des.c => crypto/desrfb.c | 2 +-
> ui/d3des.h => include/crypto/desrfb.h | 0
> ui/Makefile.objs | 2 +-
> ui/vnc.c | 2 +-
> 5 files changed, 4 insertions(+), 3 deletions(-)
> rename ui/d3des.c => crypto/desrfb.c (99%)
> rename ui/d3des.h => include/crypto/desrfb.h (100%)
Reviewed-by: Gonglei <address@hidden>
- [Qemu-devel] [PATCH v3 00/10] Consolidate crypto APIs & implementations, Daniel P. Berrange, 2015/06/18
- [Qemu-devel] [PATCH v3 03/10] crypto: move built-in D3DES implementation into crypto/, Daniel P. Berrange, 2015/06/18
- Re: [Qemu-devel] [PATCH v3 03/10] crypto: move built-in D3DES implementation into crypto/,
Gonglei <=
- [Qemu-devel] [PATCH v3 01/10] crypto: introduce new module for computing hash digests, Daniel P. Berrange, 2015/06/18
- [Qemu-devel] [PATCH v3 02/10] crypto: move built-in AES implementation into crypto/, Daniel P. Berrange, 2015/06/18
- [Qemu-devel] [PATCH v3 07/10] block: convert quorum blockdrv to use crypto APIs, Daniel P. Berrange, 2015/06/18
- [Qemu-devel] [PATCH v3 04/10] crypto: introduce generic cipher API & built-in implementation, Daniel P. Berrange, 2015/06/18
- [Qemu-devel] [PATCH v3 05/10] crypto: add a gcrypt cipher implementation, Daniel P. Berrange, 2015/06/18
- [Qemu-devel] [PATCH v3 06/10] crypto: add a nettle cipher implementation, Daniel P. Berrange, 2015/06/18