[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/21] Trivial patches for 2015-06-22
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PULL 00/21] Trivial patches for 2015-06-22 |
Date: |
Tue, 23 Jun 2015 20:08:33 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 |
22.06.2015 19:02, Peter Maydell wrote:
> Fails to build on Windows:
>
> util/qemu-sockets.c: In function ‘inet_parse_connect_opts’:
> util/qemu-sockets.c:338: error: ‘AI_V4MAPPED’ undeclared (first use in this
> function)
Hmm. Does WIN really have no AI_V4MAPPED? Does it have getaddrinfo
in the first place? If yes, it should have AI_V4MAPPED too.
I added a conditional #define AI_V4MAPPED to 0 at the top of this
file, the same way AI_ADDRCONFIG is handled.
> (Also I had to resolve a conflict in configure, so if you rebase
> on current master you'll save me having to do it twice...)
Immediately before sending the pull request, I did a rebase and rebuild.
Apparently you pulled some other change before trying to pull this.
I usually rebase right before sending the request. Just did the
rebase again, and fixed he conflict with guest-agent-msi change.
Will resend the pull request.
Thanks,
/mjt
- [Qemu-devel] [PULL 15/21] qemu-options: Improve -global documentation, (continued)
- [Qemu-devel] [PULL 15/21] qemu-options: Improve -global documentation, Michael Tokarev, 2015/06/22
- [Qemu-devel] [PULL 05/21] pci-assign: QOMify, Michael Tokarev, 2015/06/22
- [Qemu-devel] [PULL 11/21] libcacard: pkgconfig: tidy dependent libs, Michael Tokarev, 2015/06/22
- [Qemu-devel] [PULL 03/21] Grammar: 'as to'->'as for', Michael Tokarev, 2015/06/22
- [Qemu-devel] [PULL 13/21] hw/display/qxl-logger.c: Constify some variable, Michael Tokarev, 2015/06/22
- [Qemu-devel] [PULL 12/21] configure: rearrange --help and consolidate enable/disable together, Michael Tokarev, 2015/06/22
- [Qemu-devel] [PULL 16/21] qemu-options: Use @itemx where appropriate, Michael Tokarev, 2015/06/22
- [Qemu-devel] [PULL 02/21] remove libdecnumber/dpd/decimal128Local.h, Michael Tokarev, 2015/06/22
- Re: [Qemu-devel] [PULL 00/21] Trivial patches for 2015-06-22, Peter Maydell, 2015/06/22