Re: [Qemu-devel] [PATCH v7 3/4] i.MX: Add i.MX25 3DS evaluation board support

[Jean-Christophe DUBOIS]

Le 24/06/2015 07:07, Peter Crosthwaite a écrit :
> On Mon, Jun 22, 2015 at 12:06 PM, Jean-Christophe Dubois
> <address@hidden> wrote:
> > For now we support:
> >      * timers (GPT and EPIT)
> >      * serial ports
> >      * ethernet (through the newly added FEC emulator)
> >      * I2C (through the newly added I2C emulator)
> >
> > Signed-off-by: Jean-Christophe Dubois <address@hidden>
> > ---
> >
> > Changes since v1:
> >      * Added a ds1338 I2C device for qtest purpose.
> >
> > Changes since v2:
> >      * none
> >
> > Changes since v3:
> >      * Rework GPL header
> >      * use I2C constructor helper.
> >
> > Changes since v4:
> >      * use sysbus_create_simple() instead of I2C constructor helper
> >
> > Changes since v5:
> >      * Add ds1338 only for qtest mode.
> >      * small comment fixes.
> >
> > Changes since v6:
> >      * Allow for more than 4 serial if suppoted by Qemu.
> >
> >   hw/arm/Makefile.objs |   1 +
> >   hw/arm/imx25_3ds.c   | 273 +++++++++++++++++++++++++++++++++++++++++++++++++++
> So the (new since v6) guideline with ARM SoCs is to split the SoC and
> machine models. This would give you two files. A SoC file for imx25
> and board for 3ds.
>
> I'm not 100% on the "3ds" board following some googling but is it
> really the PDK board? I found this:
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=635baf6b40ebaef683abf87d677467cba71a0d50
>
> and can find product info for PDK from there:
>
> http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=IMX25PDK
Yes this is the board.

> To see modern examples of split SoC/board, see stm32f205_soc wiith
> netduino2 or xlnx-zynqmp with xlnx-ep108 (all in hw/arm).
I'll look at it.
> It seems the only board level feature you are implementing is this
> ds1338 which is not or the real board. So I guess qtest-only code can
> be left in the SoC model.
OK
> This would make your board level very similar to netduino2 (perhaps
> even slightly simpler).
Yes, for now there is basically only the SOC supported in my case.
> Regards,
> Peter
Thanks for the feedback.

JC