[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.
From: |
Pavel Dovgaluk |
Subject: |
Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h |
Date: |
Wed, 24 Jun 2015 14:40:28 +0300 |
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> On 31/05/2015 08:11, Peter Crosthwaite wrote:
> > + /* If not executing code then assume we are ok. */
> > + if (cpu->current_tb == NULL) {
> > + return true;
> > + }
> > + return cpu->can_do_io != 0;
>
> For what it's worth, I think the "if" here is dead. Pavel?
cpu_can_do_io can be called from cpus.c and translate-all.c
In both cases these calls could be made outside the generated code.
Pavel Dovgalyuk