[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] target-i386: avoid overflow in the tsc-frequency pr
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH] target-i386: avoid overflow in the tsc-frequency property |
Date: |
Wed, 24 Jun 2015 14:11:27 +0200 |
The TSC frequency fits comfortably in an int when expressed in kHz,
but it may overflow when converted to Hz. In this case,
tsc-frequency returns a negative value because x86_cpuid_get_tsc_freq
does a 32-bit multiplication before assigning to int64_t.
For simplicity just make tsc_khz a 64-bit value.
Spotted by Coverity.
Signed-off-by: Paolo Bonzini <address@hidden>
---
target-i386/cpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 603aaf0..2125049 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -958,7 +958,7 @@ typedef struct CPUX86State {
uint8_t has_error_code;
uint32_t sipi_vector;
bool tsc_valid;
- int tsc_khz;
+ int64_t tsc_khz;
void *kvm_xsave_buf;
uint64_t mcg_cap;
--
2.4.3
- [Qemu-devel] [PATCH] target-i386: avoid overflow in the tsc-frequency property,
Paolo Bonzini <=