[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_d
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del |
Date: |
Thu, 25 Jun 2015 14:18:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
Ping?
Paolo
On 28/05/2015 16:17, Paolo Bonzini wrote:
> bdrv_close already does that, and in fact hmp_drive_del would need
> another drain after the flush (which bdrv_close does). So remove
> the duplication.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> blockdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 5eaf77e..d506a70 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2143,9 +2143,6 @@ int hmp_drive_del(Monitor *mon, const QDict *qdict,
> QObject **ret_data)
> return -1;
> }
>
> - /* quiesce block driver; prevent further io */
> - bdrv_drain_all();
> - bdrv_flush(bs);
> bdrv_close(bs);
>
> /* if we have a device attached to this BlockDriverState
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del,
Paolo Bonzini <=