[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled |
Date: |
Thu, 25 Jun 2015 13:51:26 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jun 24, 2015 at 07:35:05PM +0200, Max Reitz wrote:
> On 12.06.2015 12:09, Stefan Hajnoczi wrote:
> >Reclaim the dirty bitmap if an incremental backup block job is
> >cancelled. The ret variable may be 0 when the job is cancelled so it's
> >not enough to check ret < 0.
> >
> >Signed-off-by: Stefan Hajnoczi <address@hidden>
> >---
> > block/backup.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/block/backup.c b/block/backup.c
> >index d3f648d..c1ad975 100644
> >--- a/block/backup.c
> >+++ b/block/backup.c
> >@@ -430,7 +430,7 @@ static void coroutine_fn backup_run(void *opaque)
> > if (job->sync_bitmap) {
> > BdrvDirtyBitmap *bm;
> >- if (ret < 0) {
> >+ if (ret < 0 || block_job_is_cancelled(&job->common)) {
> > /* Merge the successor back into the parent, delete nothing. */
> > bm = bdrv_reclaim_dirty_bitmap(bs, job->sync_bitmap, NULL);
> > assert(bm);
>
> Since I can't find a seperate patch on qemu-devel or qemu-block yet:
>
> Reviewed-by: Max Reitz <address@hidden>
Thanks, I must have gotten distracted before sending the email.
pgpMikyjsFnbP.pgp
Description: PGP signature
- [Qemu-devel] [RFC 0/9] block: incremental backup transactions using BlockJobTxn, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 1/9] qapi: Add transaction support to block-dirty-bitmap operations, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 2/9] iotests: add transactional incremental backup test, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 3/9] block: rename BlkTransactionState and BdrvActionOps, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 5/9] block: add block job transactions, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 6/9] blockdev: make BlockJobTxn available to qmp 'transaction', Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 7/9] block/backup: support block job transactions, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 8/9] iotests: 124 - transactional failure test, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [RFC 9/9] qmp-commands.hx: Update the supported 'transaction' operations, Stefan Hajnoczi, 2015/06/12