[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.4] e1000: flush packets when link comes up
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH for-2.4] e1000: flush packets when link comes up |
Date: |
Thu, 25 Jun 2015 15:24:00 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jun 25, 2015 at 10:18:05AM +0100, Stefan Hajnoczi wrote:
> e1000_can_receive() checks the link up status register bit. If the bit
> is clear, packets will be queued and the peer may disable receive to
> avoid wasting CPU reading packets that cannot be delivered. The queue
> must be flushed once the link comes back up again.
>
> This patch fixes broken e1000 receive with Mac OS X Snow Leopard guests
> and tap networking. Flushing the queue invokes the async send callback,
> which re-enables tap fd read.
>
> Reported-by: Jonathan Liu <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/net/e1000.c | 3 +++
> 1 file changed, 3 insertions(+)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
pgpPpOvNdUM2X.pgp
Description: PGP signature