[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/5] Refactoring pc_dimm_plug and NUMA node l
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/5] Refactoring pc_dimm_plug and NUMA node lookup API |
Date: |
Fri, 26 Jun 2015 15:09:06 +1000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 26, 2015 at 09:35:59AM +0530, Bharata B Rao wrote:
> Hi,
>
> Here is the v3 of the patchset that refactors pc_dimm_plug and adds
> an API to lookup NUMA node by address.
>
> - Refactoring pc_dimm_plug() helps other architectures like PowerPC
> to make use of common code.
> - API to lookup NUMA node id by address is required to support memory
> hotplug on PowerPC sPAPR guests.
>
> The patchset that adds memory hotplug support to PowerPC sPAPR that
> was posted at
> http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg06574.html
> depends on this patchset.
>
> Changes in v3:
> -------------
> - Not calling pc_dimm_memory_unplug() when pc_dimm_memory_plug() fails
> because when pc_dimm_memory_plug() fails, it wouldn't have done
> memory_region_add_subregion() and vmstate_register_ram().
> - As per Igor's suggestion, moving of hotplug related fields from
> PCMachineState is now in a separate patch.
>
> v2: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg05157.html
> v1: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg03212.html
> v0: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01078.html
>
> Bharata B Rao (5):
> pc,pc-dimm: Extract hotplug related fields in PCMachineState to a
> structure
> pc,pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate
> routine
> numa,pc-dimm: Store pc-dimm memory information in numa_info
> numa: Store boot memory address range in node_info
> numa: API to lookup NUMA node by address
>
> hw/i386/acpi-build.c | 2 +-
> hw/i386/pc.c | 84
> +++++++++---------------------------------------
> hw/mem/pc-dimm.c | 84
> ++++++++++++++++++++++++++++++++++++++++++++++++
> include/hw/i386/pc.h | 7 ++--
> include/hw/mem/pc-dimm.h | 15 +++++++++
> include/sysemu/numa.h | 11 +++++++
> numa.c | 77 ++++++++++++++++++++++++++++++++++++++++++++
> 7 files changed, 205 insertions(+), 75 deletions(-)
Looks good to me. I'm hoping this can be merged pretty soon, so I can
then pull the actual pseries hotplug memory stuff into spapr-next.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpMx7Wsf91fz.pgp
Description: PGP signature