[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler |
Date: |
Fri, 26 Jun 2015 12:05:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 26/06/2015 11:19, Igor Mammedov wrote:
> That's one of the reasons, I've asked to get rid of icc-bus.
>
> Another reason is to move default APIC MMIO mapping to CPU from board
> and handle region remapping from CPU itself as it's supposed to be if CPU
> would program another APIC base.
>
> Paolo,
> would following change be acceptable:
>
> x86_cpu_realize() {
> if (tcg) {
> memory_region_add_subregion_overlap(cpu->as, apic->mr)
> } else {
> if (map_once)
> memory_region_add_subregion_overlap(get_system_memory(), apic->mr)
> }
> }
> still a hack but a localized to CPU
Yes, this is better.
Paolo
[Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Zhu Guihua, 2015/06/24
- Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Andreas Färber, 2015/06/25
- Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Paolo Bonzini, 2015/06/25
- Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Zhu Guihua, 2015/06/30
- Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Igor Mammedov, 2015/06/30
- Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Zhu Guihua, 2015/06/30
- Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Peter Maydell, 2015/06/30
- Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Eduardo Habkost, 2015/06/30
Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Andreas Färber, 2015/06/30
Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler, Eduardo Habkost, 2015/06/30
[Qemu-devel] [RESEND PATCH v8 3/4] cpu/apic: drop icc bus/bridge, Zhu Guihua, 2015/06/24
[Qemu-devel] [RESEND PATCH v8 4/4] icc_bus: drop the unused files, Zhu Guihua, 2015/06/24