[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build-sys: keep current config.log on --help
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] build-sys: keep current config.log on --help |
Date: |
Fri, 26 Jun 2015 14:26:21 +0100 |
On 25 June 2015 at 23:38, Marc-André Lureau <address@hidden> wrote:
> It's nice to keep the config.log used to configure the build.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> configure | 35 +++++++++++++++++++----------------
> 1 file changed, 19 insertions(+), 16 deletions(-)
>
> diff --git a/configure b/configure
> index 1626c2e..dcd15a9 100755
> --- a/configure
> +++ b/configure
> @@ -29,14 +29,7 @@ TMPL="${TMPDIR1}/${TMPB}.lo"
> TMPA="${TMPDIR1}/lib${TMPB}.la"
> TMPE="${TMPDIR1}/${TMPB}.exe"
>
> -rm -f config.log
> -
> -# Print a helpful header at the top of config.log
> -echo "# QEMU configure log $(date)" >> config.log
> -printf "# Configured with:" >> config.log
> -printf " '%s'" "$0" "$@" >> config.log
> -echo >> config.log
> -echo "#" >> config.log
> +CONFIG_LOG="/dev/null"
Doesn't this mean we're now going to just drop a bunch of the
logging on the floor in the case where the user didn't say --help?
That doesn't sound great...
If we want to do this I think we should identify the "--help"
case earlier, not just drop all the logging until we reach
the point in configure where we happen to identify it now.
thanks
-- PMM