Re: [Qemu-devel] [PATCH v2 00/16] ahci: ncq cleanup, part 1

[Stefan Hajnoczi]

On Mon, Jun 22, 2015 at 07:38:12PM -0400, John Snow wrote:
> requires: address@hidden
>           [PATCH v2 0/4] ahci: misc fixes/tests for 2.4
> 
> This series adds a couple of tests to exercise the NCQ pathways
> and establish a baseline for us.
> 
> Most of these patches are fairly short and should be relatively trivial
> to review. this series will lay the groundwork for part 2,
> which adds the rerror/werror=stop and migration support for that feature
> as well.
> 
> ===
> v2:
> 
>  - Cleared out #ifdefs to prevent unneeded bitrot
>  - Fixed migration test in patch 16
>  - Removed the forceful ide_state->error clear from patch 08,
>    replacing it instead with a change to the tests to issue
>    IDENTIFY prior to attempting any data transfer.
> 
> ________________________________________________________________________________
> 
> For convenience, this branch is available at:
> https://github.com/jnsnow/qemu.git branch ahci-ncq-s1
> https://github.com/jnsnow/qemu/tree/ahci-ncq-s1
> 
> This version is tagged ahci-ncq-s1-v2:
> https://github.com/jnsnow/qemu/releases/tag/ahci-ncq-s1-v2
> 
> John Snow (16):
>   ahci: Rename NCQFIS structure fields
>   ahci: use shorter variables
>   ahci: add ncq_err helper
>   ahci: check for ncq prdtl overflow
>   ahci: separate prdtl from opts
>   ahci: add ncq debug checks
>   ahci: ncq sector count correction
>   ahci/qtest: Execute IDENTIFY prior to data commands
>   libqos/ahci: fix cmd_sanity for ncq
>   libqos/ahci: add NCQ frame support
>   libqos/ahci: edit wait to be ncq aware
>   libqos/ahci: adjust expected NCQ interrupts
>   libqos/ahci: set the NCQ tag on command_commit
>   libqos/ahci: Force all NCQ commands to be LBA48
>   qtest/ahci: simple ncq data test
>   qtest/ahci: ncq migration test
> 
>  hw/ide/ahci.c       | 102 +++++++++++++++++++++++----------
>  hw/ide/ahci.h       |  38 ++++++++----
>  tests/ahci-test.c   |  38 ++++++++++--
>  tests/libqos/ahci.c | 162 
> +++++++++++++++++++++++++++++++++-------------------
>  tests/libqos/ahci.h |  59 ++++++++++++++-----
>  5 files changed, 281 insertions(+), 118 deletions(-)
> 
> -- 
> 2.1.0
> 

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgp0wM2PGBjjv.pgp
Description: PGP signature