[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/16] ahci: add get_cmd_header helper
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 13/16] ahci: add get_cmd_header helper |
Date: |
Fri, 26 Jun 2015 16:51:43 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 22, 2015 at 08:21:12PM -0400, John Snow wrote:
> +static AHCICmdHdr *get_cmd_header(AHCIState *s, uint8_t port, uint8_t slot)
> +{
> + if (port > s->ports || slot > AHCI_MAX_CMDS) {
Should these be >= instead of >? Otherwise 1 element beyond the end of
the array can be accessed.
pgp94kHKobvkd.pgp
Description: PGP signature
- Re: [Qemu-devel] [Qemu-block] [PATCH 06/16] ahci: record ncq failures, (continued)
- [Qemu-devel] [PATCH 07/16] ahci: kick NCQ queue, John Snow, 2015/06/22
- [Qemu-devel] [PATCH 08/16] ahci: correct types in NCQTransferState, John Snow, 2015/06/22
- [Qemu-devel] [PATCH 09/16] ahci: correct ncq sector count, John Snow, 2015/06/22
- [Qemu-devel] [PATCH 10/16] qtest/ahci: halted NCQ test, John Snow, 2015/06/22
- [Qemu-devel] [PATCH 01/16] ide: add limit to .prepare_buf(), John Snow, 2015/06/22
- [Qemu-devel] [PATCH 13/16] ahci: add get_cmd_header helper, John Snow, 2015/06/22
- Re: [Qemu-devel] [PATCH 13/16] ahci: add get_cmd_header helper,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 11/16] ahci: add cmd header to ncq transfer state, John Snow, 2015/06/22
- [Qemu-devel] [PATCH 12/16] ahci: ncq migration, John Snow, 2015/06/22
[Qemu-devel] [PATCH 15/16] qtest/ahci: halted ncq migration test, John Snow, 2015/06/22
[Qemu-devel] [PATCH 14/16] ahci: Do not map cmd_fis to generate response, John Snow, 2015/06/22