Re: [Qemu-devel] [PATCH] target-s390x: fix CONVERT TO BINARY (CVD, CVDY)

[Richard Henderson]

On 06/25/2015 08:16 PM, Aurelien Jarno wrote:
>       for (shift = 4; (shift < 64) && bin; shift += 4) {
> -        int current_number = bin % 10;
> -
> -        dec |= (current_number) << shift;
> +        dec |= (bin % 10) << shift;
>           bin /= 10;
>       }

You've changed from 32-bit division to 64-bit division just to solve a problem 
with the shift.  Better to just change the type of current_number there.


r~