[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option |
Date: |
Mon, 29 Jun 2015 11:35:23 +0100 |
On 29 June 2015 at 06:36, David Gibson <address@hidden> wrote:
> At present, the core device model code for 8250-like serial ports
> (serial.c) and the code for serial ports attached to ISA-style legacy IO
> (serial-isa.c) are both controlled by the CONFIG_SERIAL variable.
>
> There are lots and lots of embedded platforms that have 8250-like serial
> ports but have never had anything resembling ISA legacy IO. Therefore,
> split serial-isa into its own CONFIG_SERIAL_ISA option so it can be
> disabled for platforms where it's not appropriate.
>
> For now, I enabled CONFIG_SERIAL_ISA in every default-config where
> CONFIG_SERIAL is enabled, excepting microblaze, xtensa and or32. Those
> platforms have technically lost functionality, but since they have no
> other PCI or ISA devices, it's fairly clear they never actually used
> leagacy IO stuff.
s/leagacy/legacy/
Is it worth having a default-configs/isa.mak along the
lines of our current pci.mak and usb.mak, for putting
CONFIG_ defines for all ISA devices?
A quick grep suggests you can knock arm, moxie, sh4
and sh4eb off your list of things with CONFIG_SERIAL_ISA
(no hits for ISABus).
I notice in passing that we still have a handful of config
files which set CONFIG_ISA_MMIO, despite that having been
deleted in commit 61fcb628627ea4 two years ago.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc, (continued)
- Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc, Andreas Färber, 2015/06/29
- Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc, Laurent Vivier, 2015/06/29
- Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc, Andreas Färber, 2015/06/29
- Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc, Andreas Färber, 2015/06/29
- Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc, Alexander Graf, 2015/06/29
- Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc, David Gibson, 2015/06/29
- Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc, Thomas Huth, 2015/06/29
[Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option, David Gibson, 2015/06/29
[Qemu-devel] [PATCH 3/4] Split ISA and sysbus versions of m48t59 device, David Gibson, 2015/06/29