[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/6] pc: Abort if HotplugHandlerClass::plug()
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/6] pc: Abort if HotplugHandlerClass::plug() fails |
Date: |
Mon, 29 Jun 2015 13:53:21 +0200 |
On Mon, 29 Jun 2015 13:50:24 +0530
Bharata B Rao <address@hidden> wrote:
> HotplugHandlerClass::plug() shouldn't fail and hence use error_abort
> to abort if it fails.
>
> Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/i386/pc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 8df1f3e..a66416d 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1577,7 +1577,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
> }
>
> hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev);
> - hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err);
> + hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &error_abort);
> out:
> error_propagate(errp, local_err);
> }
- [Qemu-devel] [PATCH v4 0/6] Refactoring pc_dimm_plug and NUMA node lookup API, Bharata B Rao, 2015/06/29
- [Qemu-devel] [PATCH v4 2/6] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine, Bharata B Rao, 2015/06/29
- [Qemu-devel] [PATCH v4 1/6] pc, pc-dimm: Extract hotplug related fields in PCMachineState to a structure, Bharata B Rao, 2015/06/29
- [Qemu-devel] [PATCH v4 3/6] pc: Abort if HotplugHandlerClass::plug() fails, Bharata B Rao, 2015/06/29
- [Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info, Bharata B Rao, 2015/06/29
- Re: [Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info, David Gibson, 2015/06/29
- [Qemu-devel] [PATCH v4 6/6] numa: API to lookup NUMA node by address, Bharata B Rao, 2015/06/29
- [Qemu-devel] [PATCH v4 5/6] numa: Store boot memory address range in node_info, Bharata B Rao, 2015/06/29