[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation fo
From: |
Programmingkid |
Subject: |
Re: [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X |
Date: |
Mon, 29 Jun 2015 14:04:38 -0400 |
On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote:
> On 29 June 2015 at 17:54, Programmingkid <address@hidden> wrote:
>> @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = {
>> .bdrv_ioctl = hdev_ioctl,
>> .bdrv_aio_ioctl = hdev_aio_ioctl,
>> #endif
>> +
>> +#ifdef __APPLE__
>> + .bdrv_is_inserted = cdrom_is_inserted,
>> +#endif
>
> Why isn't this handled by having a bdrv_host_cdrom,
> like Linux and FreeBSD do for their CDROM support?
That would involve a lot of unnecessary work and modifications. This small
change is all that is needed.