[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive |
Date: |
Tue, 30 Jun 2015 16:35:24 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/30/2015 11:06 AM, Fam Zheng wrote:
> virtio_net_receive still does the check by calling
> virtio_net_can_receive, if the device or driver is not ready, the packet
> is dropped.
>
> This is necessary because returning false from can_receive complicates
> things: the peer would disable sending until we explicitly flush the
> queue.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> hw/net/virtio-net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index d728233..dbef0d0 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -1503,7 +1503,6 @@ static int virtio_net_load_device(VirtIODevice *vdev,
> QEMUFile *f,
> static NetClientInfo net_virtio_info = {
> .type = NET_CLIENT_OPTIONS_KIND_NIC,
> .size = sizeof(NICState),
> - .can_receive = virtio_net_can_receive,
> .receive = virtio_net_receive,
> .link_status_changed = virtio_net_set_link_status,
> .query_rx_filter = virtio_net_query_rxfilter,
A side effect of this patch is it will read and then drop packet is
guest driver is no ok.