[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Fix MIPS N64 trap and break instruc
From: |
Leon Alrae |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Fix MIPS N64 trap and break instruction bug |
Date: |
Tue, 30 Jun 2015 14:18:10 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 29/06/2015 11:20, Andrew Bennett wrote:
> From: Andrew Bennett <address@hidden>
>
> For the MIPS N64 ABI when QEMU reads the break/trap instruction so that
> it can inspect the break/trap code it reads 8 rather than 4 bytes
> which means it finds the code field from the instruction after the
> break/trap instruction. This then causes the break/trap handling
> code to fail because it does not understand the code number.
>
> The fix forces QEMU to always read 4 bytes of instruction data rather
> than deciding how much to read based on the ABI.
>
> Signed-off-by: Andrew Bennett <address@hidden>
> ---
> linux-user/main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Leon Alrae <address@hidden>
Thanks,
Leon