[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit mode |
Date: |
Tue, 30 Jun 2015 10:36:29 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Jun 30, 2015 at 10:38:53AM +0200, Gerd Hoffmann wrote:
> virtio version 1.0 registers can (and actually do in the qemu
> implementation) live in mmio space. So we must run the blk and
> scsi virtio drivers in 32bit mode, otherwise we can't access them.
>
> This also allows to drop a bunch of GET_LOWFLAT calls from the virtio
> code in the following patches.
I think this patch is missing a "if (!MODESEGMENT)" check in
src/hw/blockcmd.c - otherwise the virtio scsi code will still be
included in the 16bit section.
Also, this patch (or a follow up patch) should update the Makefile to
not compile the virtio code in 16bit mode.
-Kevin
- [Qemu-devel] [PATCH v2 00/22] virtio: add version 1.0 support, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 01/22] pci: allow to loop over capabilities, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 02/22] virtio: run drivers in 32bit mode, Gerd Hoffmann, 2015/06/30
- Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit mode,
Kevin O'Connor <=
- [Qemu-devel] [PATCH v2 10/22] virtio: add read/write functions and macros, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 08/22] virtio: create vp_cap struct for legacy bar, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 06/22] virtio: add version 0.9.5 struct, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 04/22] virtio: pass struct pci_device to vp_init_simple, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 09/22] virtio: add version 0.9.5 struct [fixup], Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 12/22] virtio: add version 1.0 support to vp_{get, set}_status, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 13/22] virtio: add version 1.0 support to vp_get_isr, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 16/22] virtio: remove unused vp_del_vq, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 14/22] virtio: add version 1.0 support to vp_reset, Gerd Hoffmann, 2015/06/30
- [Qemu-devel] [PATCH v2 11/22] virtio: make features 64bit, support version 1.0 features, Gerd Hoffmann, 2015/06/30