Re: [Qemu-devel] [PATCH 4/6] virtio-serial: convert to virtio_map

[Igor Mammedov]

On Tue, 27 Oct 2015 10:48:03 +0200
"Michael S. Tsirkin" <address@hidden> wrote:

> This also fixes a minor bug:
> -                virtqueue_map_sg(port->elem.out_sg, port->elem.out_addr,
> -                                 port->elem.out_num, 1);
> is wrong: out_sg is not written so should not be marked dirty.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  hw/char/virtio-serial-bus.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index be97058..497b0af 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -705,10 +705,7 @@ static int fetch_active_ports_list(QEMUFile *f, int 
> version_id,
>  
>                  qemu_get_buffer(f, (unsigned char *)&port->elem,
>                                  sizeof(port->elem));
> -                virtqueue_map_sg(port->elem.in_sg, port->elem.in_addr,
> -                                 port->elem.in_num, 1);
> -                virtqueue_map_sg(port->elem.out_sg, port->elem.out_addr,
> -                                 port->elem.out_num, 1);
> +                virtqueue_map(&port->elem);
>  
>                  /*
>                   *  Port was throttled on source machine.  Let's