[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v12 15/18] qom: Wrap prop visit in visit_start_struc
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v12 15/18] qom: Wrap prop visit in visit_start_struct |
Date: |
Mon, 29 Feb 2016 22:14:29 -0700 |
The qmp-input visitor was playing rather fast and loose: when
visiting a QDict, you could grab members of the root dictionary
without first pushing into the dict. But we are about to tighten
the input visitor, at which point user_creatable_add_type() MUST
follow the same paradigms as everyone else, of pushing into the
struct before grabbing its keys, because the value of 'name'
should be ignored on the top-level visit.
The change has no impact to the testsuite now, but is required to
avoid a failure in tests/test-netfilter once qmp-input is made
stricter.
Signed-off-by: Eric Blake <address@hidden>
---
v12: new patch
---
qom/object_interfaces.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index f075b3a..8efb8d1 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -117,12 +117,23 @@ Object *user_creatable_add_type(const char *type, const
char *id,
obj = object_new(type);
if (qdict) {
+ visit_start_struct(v, NULL, NULL, 0, &local_err);
+ if (local_err) {
+ goto out;
+ }
for (e = qdict_first(qdict); e; e = qdict_next(qdict, e)) {
object_property_set(obj, v, e->key, &local_err);
if (local_err) {
- goto out;
+ break;
}
}
+ if (!local_err) {
+ visit_check_struct(v, &local_err);
+ }
+ visit_end_struct(v);
+ if (local_err) {
+ goto out;
+ }
}
object_property_add_child(object_get_objects_root(),
--
2.5.0
- [Qemu-devel] [PATCH v12 00/18] qapi visitor cleanups (post-introspection cleanups subset E), Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 03/18] qmp: Drop dead command->type, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 01/18] qapi-visit: Add visitor.type classification, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 10/18] qmp: Support explicit null during visits, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 05/18] qmp-input: Don't consume input when checking has_member, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 07/18] qapi: Document visitor interfaces, add assertions, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 02/18] qapi: Guarantee NULL obj on input visitor callback error, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 12/18] qmp: Tighten output visitor rules, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 14/18] qapi-commands: Wrap argument visit in visit_start_struct, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 15/18] qom: Wrap prop visit in visit_start_struct,
Eric Blake <=
- [Qemu-devel] [PATCH v12 16/18] qmp-input: Require struct push to visit members of top dict, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 04/18] qmp-input: Clean up stack handling, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 08/18] tests: Add check-qnull, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 11/18] spapr_drc: Expose 'null' in qom-get when there is no fdt, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 13/18] qapi: Split visit_end_struct() into pieces, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 18/18] qapi: Change visit_type_FOO() to no longer return partial objects, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 09/18] qapi: Add visit_type_null() visitor, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 17/18] qapi: Simplify semantics of visit_next_list(), Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 06/18] qmp-input: Refactor when list is advanced, Eric Blake, 2016/03/01