[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 30/38] ivshmem: Simplify memory regions for BAR
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 30/38] ivshmem: Simplify memory regions for BAR 2 (shared memory) |
Date: |
Tue, 01 Mar 2016 13:14:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 29/02/2016 19:40, Markus Armbruster wrote:
>> ivshmem_realize() puts the shared memory region in a container region.
>> Used to be necessary to permit delayed mapping of the shared memory.
>> Now we don't do that anymore, the container is redundant. Drop it.
>
> Can you explain why we don't do that anymore to someone who hasn't read
> patches 4 to 28? :-) Is it patch 23?
Yes, but you also need 24 to complete the job.
Commit message could perhaps explain it like this:
ivshmem_realize() puts the shared memory region in a container
region. Used to be necessary to permit delayed mapping of the
shared memory. However, we recently moved to synchronous mapping,
in "ivshmem: Receive shared memory synchronously in realize()" and
the commit following it. The container is redundant since then.
Drop it.
Better?