[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/13] vl: fix tracing initialization
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 05/13] vl: fix tracing initialization |
Date: |
Tue, 1 Mar 2016 15:48:06 +0000 |
From: "Denis V. Lunev" <address@hidden>
we should call trace_init_backends() before trace_init_file() for
CONFIG_TRACE_SIMPLE There is no difference for other cases.
This problem was introduced by the commit
commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
Author: Paolo Bonzini <address@hidden>
Date: Thu Jan 7 16:55:24 2016 +0300
trace: split trace_init_file out of trace_init_backends
'make check' was failed as a result if configured with
--enable-trace-backends=simple
Spotted by Alex Bennée.
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Message-id: address@hidden
CC: Alex Bennée <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
vl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index b87e292..adeddd9 100644
--- a/vl.c
+++ b/vl.c
@@ -4081,6 +4081,9 @@ int main(int argc, char **argv, char **envp)
exit(0);
}
+ if (!trace_init_backends()) {
+ exit(1);
+ }
trace_init_file(trace_file);
/* Open the logfile at this point and set the log mask if necessary.
@@ -4101,10 +4104,6 @@ int main(int argc, char **argv, char **envp)
qemu_set_log(0);
}
- if (!trace_init_backends()) {
- exit(1);
- }
-
/* If no data_dir is specified then try to find it relative to the
executable path. */
if (data_dir_idx < ARRAY_SIZE(data_dir)) {
--
2.5.0
- [Qemu-devel] [PULL 00/13] Tracing patches, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 02/13] trace: docs: "simple" backend does support strings, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 01/13] trace: drop trailing empty strings, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 06/13] trace: Extend API to manage event arguments, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 04/13] trace: use addresses instead of offsets in memory tracepoints, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 03/13] trace: split subpage MMIOs into their own trace events., Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 05/13] vl: fix tracing initialization,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 07/13] trace: Remove unnecessary intermediate event copies, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 08/13] tcg: Add type for vCPU pointers, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 10/13] trace: Add helper function to cast event arguments, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 11/13] typedefs: Add CPUState, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 09/13] tcg: Move definition of type TCGv, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 12/13] trace: Add 'vcpu' event property to trace guest vCPU, Stefan Hajnoczi, 2016/03/01
- [Qemu-devel] [PULL 13/13] trace: Add a proper API to manage auto-generated events from the 'tcg' property, Stefan Hajnoczi, 2016/03/01
- Re: [Qemu-devel] [PULL 00/13] Tracing patches, Peter Maydell, 2016/03/01