[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from Rng
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend |
Date: |
Wed, 2 Mar 2016 12:45:47 +0530 |
On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote:
> RngBackend is now in charge of cleaning up the linked list on
> instance finalization. It also exposes a function to finalize
> individual RngRequest instances, called by its child classes.
>
> Signed-off-by: Ladi Prosek <address@hidden>
> @@ -183,8 +162,6 @@ static void rng_egd_finalize(Object *obj)
> }
>
> g_free(s->chr_name);
> -
> - rng_egd_free_requests(s);
Missing call to rng_backend_free_requests()?
> diff --git a/include/sysemu/rng.h b/include/sysemu/rng.h
> index 084164c..c2c9035 100644
> --- a/include/sysemu/rng.h
> +++ b/include/sysemu/rng.h
> @@ -61,6 +61,7 @@ struct RngBackend
> GSList *requests;
> };
>
> +
> /**
Extra whitespace?
Amit
- Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend,
Amit Shah <=