[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 5/6] s390x/cpu: Add error handling to cpu cre
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v7 5/6] s390x/cpu: Add error handling to cpu creation |
Date: |
Wed, 2 Mar 2016 08:59:20 +0100 |
> Check for and propogate errors during s390 cpu creation.
>
> Signed-off-by: Matthew Rosato <address@hidden>
> ---
> hw/s390x/s390-virtio-ccw.c | 30 +++++++++++++++++++++
> hw/s390x/s390-virtio.c | 2 +-
> hw/s390x/s390-virtio.h | 1 +
> target-s390x/cpu-qom.h | 3 +++
> target-s390x/cpu.c | 65
> ++++++++++++++++++++++++++++++++++++++++++++--
> target-s390x/cpu.h | 1 +
> target-s390x/helper.c | 31 ++++++++++++++++++++--
> 7 files changed, 128 insertions(+), 5 deletions(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 3090e76..4886dbf 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -112,6 +112,36 @@ void s390_memory_init(ram_addr_t mem_size)
> s390_skeys_init();
> }
>
> +S390CPU *s390_new_cpu(MachineState *machine, int64_t id, Error **errp)
Just a thought, if not passing machine but the model string, we could make
cpu_s390x_init() call s390_new_cpu().
But then s390_new_cpu() would have to be moved again. Not sure if this is
really worth it.
David
- Re: [Qemu-devel] [PATCH v7 4/6] s390x/cpu: Add CPU property links, (continued)
- Re: [Qemu-devel] [PATCH v7 5/6] s390x/cpu: Add error handling to cpu creation,
David Hildenbrand <=
[Qemu-devel] [PATCH v7 3/6] s390x/cpu: Move some CPU initialization into realize, Matthew Rosato, 2016/03/01