[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType |
Date: |
Wed, 2 Mar 2016 18:55:58 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Mar 02, 2016 at 10:47:39AM +0100, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
> > If temporarily not considering kernel_irqchip=split case:
> >
> > [{
> > "version": 2,
> > "emulated": true,
> > "kernel": true
> > },
> > {
> > "version": 3,
> > "emulated": false,
> > "kernel": true
> > }]
> >
> > To use array rather than dict so that we do not need to change qapi
> > schema again when GICv4 comes.
>
> Drive-by shooting without sufficient context: we may *want* to change
> the QAPI schema, because that makes the change introspectable with
> query-schema.
Failed to catch the point. :(
What's "query-schema"? Is that a QMP command?
What I meant is that, we can define the following (for example):
{ 'struct': 'GICCapInfo',
'data': [
'version': 'int',
'emulated': 'bool',
'kernel': 'bool'] }
And:
{ 'command': 'query-gic-capability',
'returns': ['GICCapInfo'] }
So we can keep this schema as it is when new versions arrive. We
can just push another element in.
Peter
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType, Andrea Bolognani, 2016/03/01
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType, Peter Xu, 2016/03/01
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType, Peter Xu, 2016/03/02
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType, Markus Armbruster, 2016/03/02
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType,
Peter Xu <=
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType, Markus Armbruster, 2016/03/02
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType, Peter Xu, 2016/03/02
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType, Markus Armbruster, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType, Peter Xu, 2016/03/03