[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit |
Date: |
Wed, 02 Mar 2016 16:55:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Programmingkid <address@hidden> writes:
> On Mar 2, 2016, at 4:32 AM, Markus Armbruster wrote:
>
>> Programmingkid <address@hidden> writes:
>>
>>> This patch adds the file MacKeys.h. It is a file that contains all the
>>> constants
>>> for the Macintosh keyboard keycodes.
>>>
>>> Signed-off-by: John Arbuckle <address@hidden>
>>>
>>> ---
>>> Added standard license.
>>> Added #ifndef #define #endif macros.
>>>
>>> include/hw/input/MacKeys.h | 168
>>> ++++++++++++++++++++++++++++++++++++++++++++
>>
>> Please stick to lower case in file names.
>>
>> $ git-ls-files | grep '[A-Z][a-z]' | grep -v Makefile
>> Changelog
>> docs/vnc-ledstate-Pseudo-encoding.txt
>> include/libdecnumber/decContext.h
>> include/libdecnumber/decNumber.h
>> include/libdecnumber/decNumberLocal.h
>> include/libdecnumber/dpd/decimal128Local.h
>> libdecnumber/decContext.c
>> libdecnumber/decNumber.c
>
> Which one do you prefer: mackeys.h or macKeys.h ?
I'd call it mac-keys.h. mackeys.h would be okay. There's enough
precedence for '_' in file names to justify mac_keys.h, but I personally
dislike that.
- [Qemu-devel] [PATCH v2] MacKeys.h: initial commit, Programmingkid, 2016/03/01
- Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit, Markus Armbruster, 2016/03/02
- Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit, Programmingkid, 2016/03/02
- Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit, Eric Blake, 2016/03/02
- Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit, Peter Maydell, 2016/03/02
- Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit, Programmingkid, 2016/03/02
- Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit, Programmingkid, 2016/03/02
- Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit, Peter Maydell, 2016/03/02